Replace dependency 'request' with built-in fetch() API#365
Merged
mikeharder merged 19 commits intomainfrom Aug 29, 2025
Merged
Conversation
Contributor
Author
|
@mikeharder 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs. I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review. |
Co-authored-by: mikeharder <9459391+mikeharder@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Remove dependency "request"
Remove deprecated request dependency and replace with built-in fetch API
Aug 29, 2025
mikeharder
reviewed
Aug 29, 2025
mikeharder
reviewed
Aug 29, 2025
mikeharder
reviewed
Aug 29, 2025
mikeharder
reviewed
Aug 29, 2025
mikeharder
reviewed
Aug 29, 2025
mikeharder
reviewed
Aug 29, 2025
| } | ||
|
|
||
| try { | ||
| return parseContent(options.url, responseBody) |
Member
There was a problem hiding this comment.
No longer need to check type of responseBody, because response.text() is always string.
scbedd
approved these changes
Aug 29, 2025
raych1
approved these changes
Aug 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
requestlibrary is deprecated and no longer maintained. This PR removes the dependency and replaces its usage with Node.js's built-infetch()API, which is available in Node.js ≥ 18.0.0 (this project requires ≥ 18.0.0).Changes Made
requestdependency frompackage.jsonand@types/requestfrom devDependenciesmakeRequest()function insrc/lib/util/utils.tsto usefetch()instead of the request libraryResponsetype that was specific to the request libraryBefore/After
Before:
After:
The function signature and behavior remain identical from the caller's perspective, ensuring backward compatibility.
Testing
Fixes #360.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
httpbin.orgnode /tmp/test-makeRequest.js(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.